fix(server): interrupt turns after approval cancellation - #5429

Note

Interrupt provider turn after approval cancellation in ProviderCommandReactor

• On thread.approval.respond events, the reactor now calls providerService.interruptTurn only when the decision is cancel and the approval response succeeds; declines are forwarded without interrupting.
• If respondToRequest fails, a provider.approval.respond.failed activity is recorded and the interrupt is skipped.
• If the interrupt itself fails, a provider.turn.interrupt.failed activity is recorded with the active turn ID and error detail.
• Behavioral Change: approval cancellations now trigger a turn interrupt as a second step, whereas previously they did not.

^{Macroscope summarized 5c752ea.}

Note

Medium Risk
Changes approval-handling orchestration and turn interruption timing in the provider reactor, which affects live agent sessions but is narrowly scoped and covered by new tests.

Overview
Fixes a case where cancelling an approval only told the provider the request was cancelled, so the same turn could keep running and prompt for more approvals.

ProviderCommandReactor now calls interruptTurn only when the approval decision is cancel and respondToRequest succeeds. decline still only forwards the response (no interrupt). If the approval response fails, the turn is not interrupted. A failed interrupt after a successful cancel is recorded as a provider.turn.interrupt.failed activity.

New ProviderCommandReactor tests cover decline-without-interrupt, cancel ordering (respond then interrupt), skipped interrupt on failed cancel response, and failed interrupt logging.

^{Reviewed by Cursor Bugbot for commit 5c752ea. Bugbot is set up for automated code reviews on this repo. Configure here.}